Do not validate signatures when an integration is manually installed in the E2E tests #31530
Conversation
github-actions
bot
added
team/container-ecosystems
team/agent-delivery
short review
|
[Fast Unit Tests Report] On pipeline 50077795 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
FlorentClarret
force-pushed
the
florentclarret/integration
branch
from
e7befff
to
7760871
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50077795 --os-family=ubuntuNote: This applies to commit aaf1b82 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6686f4d Optimization Goals: ❌ Significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle | memory utilization | +0.52 | [+0.48, +0.57] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.05 | [-0.43, +0.52] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.74, +0.79] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.11, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.80, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.10 | [-0.73, +0.54] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.25 | [-1.02, +0.52] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.33 | [-0.40, -0.26] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.36 | [-1.13, +0.41] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.47 | [-0.61, -0.33] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.57 | [-1.28, +0.15] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.57 | [-1.28, +0.14] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.85 | [-0.96, -0.74] | 1 | Logs bounds checks dashboard |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -4.84 | [-8.25, -1.44] | 1 | Logs |
| ✅ | basic_py_check | % cpu utilization | -5.27 | [-9.07, -1.46] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_100ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
FlorentClarret
force-pushed
the
florentclarret/integration
branch
from
7760871
to
aaf1b82
Compare
|
Would this make sense to BP in the 6.53 branch? |
It's not needed. The list of "trusted" keys is stored in the |
|
/merge |
Devflow running:
|
pducolin
added
the
qa/no-code-change
What does this PR do?
Do not validate signatures when an integration is manually installed in the E2E tests
Motivation
In #incident-32841, we started to face issues because the key that signed the version of the integration we were trying to install got revoked (I left the team and I signed this version). Since we build the downloader from source, we started to pick up that change soon after the merge.
As discussed with @iliakur we can skip the signature validation, given this is already triple checked in the integration itself and we want to test the Agent here.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes